linux-kernel - Re: [PATCH 2/8] staging: kpc2000: use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190523122647.GB26641@kroah.com>
Date:   Thu, 23 May 2019 14:26:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Simon Sandström <simon@...anor.nu>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [PATCH 2/8] staging: kpc2000: use __func__ in debug messages

On Thu, May 23, 2019 at 02:09:37PM +0200, Simon Sandström wrote:
> On Thu, May 23, 2019 at 01:55:53PM +0200, Greg KH wrote:
> > On Thu, May 23, 2019 at 01:36:07PM +0200, Simon Sandström wrote:
> > > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
> > > '<function name>', this function's name, in a string".
> > > 
> > > Signed-off-by: Simon Sandström <simon@...anor.nu>
> > > ---
> > >  drivers/staging/kpc2000/kpc2000/cell_probe.c | 22 +++++++++++++-------
> > >  1 file changed, 14 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > index 95bfbe4aae4d..7b850f3e808b 100644
> > > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > > @@ -299,7 +299,8 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
> > >  
> > >  	kudev = kzalloc(sizeof(struct kpc_uio_device), GFP_KERNEL);
> > >  	if (!kudev) {
> > > -		dev_err(&pcard->pdev->dev, "probe_core_uio: failed to kzalloc kpc_uio_device\n");
> > > +		dev_err(&pcard->pdev->dev, "%s: failed to kzalloc kpc_uio_device\n",
> > > +			__func__);
> > 
> > kmalloc and friend error messages should just be deleted.  Didn't
> > checkpatch say something about that?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Yes sorry, it did. Should I delete this chunk from this patch and add
> another patch to this series that just deletes the message, in v2?

Yes please.

thanks,

greg k-h