linux-kernel - Re: [PATCH net] net: mvpp2: cls: Fix leaked ethtool_rx_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 May 2019 09:13:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maxime.chevallier@...tlin.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        antoine.tenart@...tlin.com, thomas.petazzoni@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH net] net: mvpp2: cls: Fix leaked ethtool_rx_flow_rule

From: Maxime Chevallier <maxime.chevallier@...tlin.com>
Date: Thu, 23 May 2019 10:47:24 +0200

> The flow_rule is only used when configuring the classification tables,
> and should be free'd once we're done using it. The current code only
> frees it in the error path.
> 
> Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Applied, thanks Maxime.