linux-kernel - Re: [PATCH] MIPS: TXx9: Fix boot crash in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR2201MB1277268FA658B58629931DC5C1010@MWHPR2201MB1277.namprd22.prod.outlook.com>
Date:   Thu, 23 May 2019 01:56:41 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        James Hogan <jhogan@...nel.org>,
        Atsushi Nemoto <anemo@....ocn.ne.jp>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        "Maciej W . Rozycki" <macro@...ux-mips.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] MIPS: TXx9: Fix boot crash in free_initmem()

Hello,

Geert Uytterhoeven wrote:
> On rbtx4927:
> 
> BUG: Bad page state in process swapper  pfn:00001
> page:804b7820 refcount:0 mapcount:-128 mapping:00000000 index:0x1
> flags: 0x0()
> raw: 00000000 00000100 00000200 00000000 00000001 00000000 ffffff7f 00000000
> page dumped because: nonzero mapcount
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.2.0-rc1-rbtx4927-00468-g3c05ea3d4077b756 #141
> Stack : 00000000 10008400 8040dc4c 87c1b974 8044af63 8040dc4c 00000001 804a3490
> 00000001 81000000 0030f231 80148558 00000003 10008400 87c1dd80 3d0f9a2c
> 00000000 00000000 804b0000 00000000 00000007 00000000 00000081 00000000
> 62722d31 00000080 804b0000 39347874 00000000 804b7820 8040ce18 81000010
> 00000001 00000007 00000001 81000000 00000018 8021de24 00000000 804a0000
> ...
> Call Trace:
> [<8010adec>] show_stack+0x74/0x104
> [<801a5e44>] bad_page+0x130/0x138
> [<801a654c>] free_pcppages_bulk+0x17c/0x3b0
> [<801a789c>] free_unref_page+0x40/0x68
> [<801120f4>] free_init_pages+0xec/0x104
> [<803bdde8>] free_initmem+0x10/0x58
> [<803bdb8c>] kernel_init+0x20/0x100
> [<801057c8>] ret_from_kernel_thread+0x14/0x1c
> 
> As of commit b93ddc4f9156205e ("mips: Reserve memory for the kernel
> image resources"), bootmem_init() no longer reserves the memory below
> the kernel, while prom_free_prom_memory() still frees it.
> 
> Fix this by reverting commit b6263ff2d6e58cc2 ("MIPS: TXx9: Implement
> prom_free_prom_memory").
> 
> Suggested-by: Serge Semin <fancer.lancer@...il.com>
> Fixes: b93ddc4f9156205e ("mips: Reserve memory for the kernel image resources")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]