linux-kernel - Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c2bd6af-92c5-2458-dc41-1ea413545347@ti.com>
Date:   Thu, 23 May 2019 14:09:49 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <jacek.anaszewski@...il.com>, <broonie@...nel.org>,
        <lgirdwood@...il.com>, <lee.jones@...aro.org>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED
 driver

Pavel

Thanks for the review

On 5/23/19 7:50 AM, Pavel Machek wrote:
> Hi!
> 
>> +++ b/drivers/leds/leds-lm36274.c
> 
>> +static int lm36274_parse_dt(struct lm36274 *lm36274_data)
>> +{
>> +	struct fwnode_handle *child = NULL;
>> +	char label[LED_MAX_NAME_SIZE];
>> +	struct device *dev = &lm36274_data->pdev->dev;
>> +	const char *name;
>> +	int child_cnt;
>> +	int ret = -EINVAL;
>> +
>> +	/* There should only be 1 node */
>> +	child_cnt = device_get_child_node_count(dev);
>> +	if (child_cnt != 1)
>> +		return ret;
> 
> I'd do explicit "return -EINVAL" here.
> 

ACK

>> +static int lm36274_probe(struct platform_device *pdev)
>> +{
>> +	struct ti_lmu *lmu = dev_get_drvdata(pdev->dev.parent);
>> +	struct lm36274 *lm36274_data;
>> +	int ret;
>> +
>> +	lm36274_data = devm_kzalloc(&pdev->dev, sizeof(*lm36274_data),
>> +				    GFP_KERNEL);
>> +	if (!lm36274_data) {
>> +		ret = -ENOMEM;
>> +		return ret;
>> +	}
> 
> And certainly do "return -ENOMEM" explicitly here.
> 

ACK

> Acked-by: Pavel Machek <pavel@....cz>
> 									Pavel
>