linux-kernel - Re: [PATCH] platform/chrome: wilco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHX4x86bnXh_xPqU4ZwuT9RpVtyDwEP1NDWbKDWmNbXfKKEVxA@mail.gmail.com>
Date:   Thu, 23 May 2019 18:15:18 -0600
From:   Nick Crews <ncrews@...omium.org>
To:     Raul E Rangel <rrangel@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Simon Glass <sjg@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Benson Leung <bleung@...omium.org>,
        Daniel Kurtz <djkurtz@...omium.org>,
        Olof Johansson <olof@...om.net>,
        Sean Paul <seanpaul@...omium.org>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Add version sysfs entries

On Tue, May 21, 2019 at 9:15 AM Raul E Rangel <rrangel@...omium.org> wrote:
>
> Add the ability to extract version information from the EC.
>
> Signed-off-by: Raul E Rangel <rrangel@...omium.org>

Looks good to me, thanks Raul!
I applied to the chromium branch, and it works.

Reviewed-by: Nick Crews <ncrews@...omium.org>
Tested-by: Nick Crews <ncrews@...omium.org>

> ---
>
> This patch is rebased on platform/chrome: wilco_ec: Add Boot on AC support.
> https://lkml.org/lkml/2019/4/16/1374
>
> That patch wasn't in the for-next branch, so I'm not 100% sure if it
> applies cleanly to for-next.

It doesn't apply cleanly :(
You can add https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git
as the platform/chrome remote to ensure that it will apply cleanly.
It would probably be good for you to re-send this after rebasing it on for-next.