linux-kernel - Re: [PATCH] locking/lockdep: remove print_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190524184431.GF9697@fuggles.cambridge.arm.com>
Date:   Fri, 24 May 2019 19:44:31 +0100
From:   Will Deacon <will.deacon@....com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/lockdep: remove print_lock_trace function

On Thu, May 16, 2019 at 09:13:26PM +0200, Anders Roxell wrote:
> gcc warns that function print_lock_trace() is unused if
> CONFIG_PROVE_LOCKING isn't set.
> 
> ../kernel/locking/lockdep.c:2820:13: warning: ‘print_lock_trace’ defined
>    but not used [-Wunused-function]
>  static void print_lock_trace(struct lock_trace *trace, unsigned int
>    spaces)
> 
> Rework so we remove the function if CONFIG_PROVE_LOCKING isn't set.
> 
> Fixes: c120bce78065 ("lockdep: Simplify stack trace handling")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  kernel/locking/lockdep.c | 4 ----
>  1 file changed, 4 deletions(-)

Acked-by: Will Deacon <will.deacon@....com>

Will