linux-kernel - Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1905250538260.7233@namei.org>
Date:   Sat, 25 May 2019 05:38:39 +1000 (AEST)
From:   James Morris <jmorris@...ei.org>
To:     David Howells <dhowells@...hat.com>
cc:     keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed()

On Wed, 22 May 2019, David Howells wrote:

> Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected
> accesses of tsk->cred, which is marked __rcu.
> 
> Fix this by passing the new cred struct to these functions from
> commit_creds() rather than the task pointer.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>


Reviewed-by: James Morris <jamorris@...ux.microsoft.com>


-- 
James Morris
<jmorris@...ei.org>