linux-kernel - Re: [PATCH v2 1/2] dma-contiguous: Abstract dma_{alloc, free}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190524034904.GA30034@Asurada-Nvidia.nvidia.com>
Date:   Thu, 23 May 2019 20:49:04 -0700
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     dann frazier <dann.frazier@...onical.com>
Cc:     Christoph Hellwig <hch@....de>,
        Robin Murphy <robin.murphy@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>, chris@...kel.net,
        linux-xtensa@...ux-xtensa.org, keescook@...omium.org,
        sfr@...b.auug.org.au, tony@...mide.com,
        Catalin Marinas <catalin.marinas@....com>, joro@...tes.org,
        Will Deacon <will.deacon@....com>, linux@...linux.org.uk,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        jcmvbkbc@...il.com, wsa+renesas@...g-engineering.com,
        akpm@...ux-foundation.org, treding@...dia.com, dwmw2@...radead.org,
        iamjoonsoo.kim@....com,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] dma-contiguous: Abstract dma_{alloc,
 free}_contiguous()

On Thu, May 23, 2019 at 08:59:30PM -0600, dann frazier wrote:
> > > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> > > index b2a87905846d..21f39a6cb04f 100644
> > > --- a/kernel/dma/contiguous.c
> > > +++ b/kernel/dma/contiguous.c
> > > @@ -214,6 +214,54 @@ bool dma_release_from_contiguous(struct device *dev, struct page *pages,
> > >         return cma_release(dev_get_cma_area(dev), pages, count);
> > >  }
> >
> > This breaks the build for me if CONFIG_DMA_CMA=n:
> >
> >   LD [M]  fs/9p/9p.o
> > ld: fs/9p/vfs_inode.o: in function `dma_alloc_contiguous':
> > vfs_inode.c:(.text+0xa60): multiple definition of
> > `dma_alloc_contiguous'; fs/9p/vfs_super.o:vfs_super.c:(.text+0x500):
> > first defined here
> >
> > Do the following insertions need to be under an #ifdef CONFIG_DMA_CMA ?
> 
> Ah, no - the problem is actually a missing "static inline" in the
> !CONFIG_DMA_CMA version of dma_alloc_contiguous().

Yea, I saw it. Thanks for the testing and pointing it out.

Sending v3.....