linux-kernel - RE: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 05:53:33 +0000
From:   Anson Huang <anson.huang@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Leonard Crestez <leonard.crestez@....com>,
        Abel Vesa <abel.vesa@....com>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put()
 in error handling

Hi, Shawn

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@...nel.org]
> Sent: Thursday, May 23, 2019 8:41 PM
> To: Anson Huang <anson.huang@....com>
> Cc: s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> Leonard Crestez <leonard.crestez@....com>; Abel Vesa
> <abel.vesa@....com>; viresh.kumar@...aro.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary
> of_node_put() in error handling
> 
> On Tue, May 21, 2019 at 09:18:43AM +0000, Anson Huang wrote:
> > of_node_put() is called after of_match_node() successfully called,
> > then in the following error handling, of_node_put() is called again
> > which is unnecessary, this patch adjusts the location of of_node_put()
> > to avoid such scenario.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> 
> Again, there are '=20' in the patch content and I cannot apply it.

I resent the patch set, please pick them up, thanks.

https://patchwork.kernel.org/patch/10959101/
https://patchwork.kernel.org/patch/10959099/

Anson.

> 
> Shawn
> 
> > ---
> >  drivers/soc/imx/soc-imx8.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
> > index b1bd8e2..944add2 100644
> > --- a/drivers/soc/imx/soc-imx8.c
> > +++ b/drivers/soc/imx/soc-imx8.c
> > @@ -86,8 +86,6 @@ static int __init imx8_soc_init(void)
> >  	if (!id)
> >  		goto free_soc;
> >
> > -	of_node_put(root);
> > -
> >  	data = id->data;
> >  	if (data) {
> >  		soc_dev_attr->soc_id = data->name;
> > @@ -106,6 +104,8 @@ static int __init imx8_soc_init(void)
> >  	if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
> >  		platform_device_register_simple("imx-cpufreq-dt", -1, NULL,
> 0);
> >
> > +	of_node_put(root);
> > +
> >  	return 0;
> >
> >  free_rev:
> > --
> > 2.7.4
> >