linux-kernel - Re: [PATCH] staging: ks7010: Remove initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aae76db5-8768-d277-e527-9e166a02f46e@gmail.com>
Date:   Fri, 24 May 2019 12:31:19 +0530
From:   Nishka Dasgupta <nishkadg.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: Remove initialisation

On 24/05/19 12:22 PM, Greg KH wrote:
> On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
>> As the initial value of the return variable result is never used, it can
>> be removed.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
>> ---
>>   drivers/staging/ks7010/ks7010_sdio.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Didn't you already send this?

I sent two patches about removing initialisation in ks7010 today, but I 
couldn't make it a patch series because the different files had 
different maintainers. I don't think I've sent this patch before, but 
it's possible I made a mistake because my local tree has not been the 
best organised lately. I apologise for the confusion.

> And please run a spell-checker on your subject line when you resend
> this :)

Is this about "initialise" (and now also "organised", "apologise", etc)? 
As far as I'm aware whether the word ends in "-ise"/"-ize" depends on 
local varieties of English, so I went with the variety I'm more used to. 
Should I stick with American/Canadian spelling variants (including "-or" 
over "-our" etc) from now on?

Nishka
> 
> thanks,
> 
> greg k-h
>