linux-kernel - RE: [PATCH] gpio: fix gpio-adp5588 build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY1PR0301MB090122CBC8CED2B6830425378E020@BY1PR0301MB0901.namprd03.prod.outlook.com>
Date:   Fri, 24 May 2019 07:10:28 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
CC:     kbuild test robot <lkp@...el.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: RE: [PATCH] gpio: fix gpio-adp5588 build errors

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@...radead.org]
> Sent: Freitag, 24. Mai 2019 00:01
> To: LKML <linux-kernel@...r.kernel.org>; linux-gpio@...r.kernel.org
> Cc: kbuild test robot <lkp@...el.com>; Hennerich, Michael <Michael.Hennerich@...log.com>; Linus Walleij
> <linus.walleij@...aro.org>; Bartosz Golaszewski <bgolaszewski@...libre.com>
> Subject: [PATCH] gpio: fix gpio-adp5588 build errors
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> The gpio-adp5588 driver uses interfaces that are provided by
> GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
> 
> Fixes these build errors:
> 
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’:
> ../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’
>             dev->gpio_chip.irq.domain, gpio));
>                           ^
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’:
> ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-
> function-declaration]
>   ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
>   ^
> ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-
> function-declaration]
>   gpiochip_set_nested_irqchip(&dev->gpio_chip,
>   ^
> 
> Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> Cc: Michael Hennerich <michael.hennerich@...log.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>
> Cc: linux-gpio@...r.kernel.org
> ---
>  drivers/gpio/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-52-rc1.orig/drivers/gpio/Kconfig
> +++ lnx-52-rc1/drivers/gpio/Kconfig
> @@ -822,6 +822,7 @@ config GPIO_ADP5588
>  config GPIO_ADP5588_IRQ
>         bool "Interrupt controller support for ADP5588"
>         depends on GPIO_ADP5588=y
> +       select GPIOLIB_IRQCHIP
>         help
>           Say yes here to enable the adp5588 to be used as an interrupt
>           controller. It requires the driver to be built in the kernel.
>