linux-kernel - Re: [PATCH v2] consolemap: Fix a memory leaking bug in con_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 10:02:00 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gen Zhang <blackgod016574@...il.com>
Cc:     jslaby@...e.com, keescook@...omium.org, khorenko@...tuozzo.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] consolemap: Fix a memory leaking bug in
 con_insert_unipair()

On Fri, May 24, 2019 at 10:19:32AM +0800, Gen Zhang wrote:
> In function con_insert_unipair(), when allocation for p2 and p1[n]
> fails, ENOMEM is returned, but previously allocated p1 is not freed, 
> remains as leaking memory. Thus we should free p1 as well when this
> allocation fails.
> 
> Signed-off-by: Gen Zhang <blackgod016574@...il.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Any reason you keep dropping me from this thread?

It's as if you don't want me to apply the patch :(

greg k-h