linux-kernel - 答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fa6fa90739d4900a1991492f377d8c0@zhaoxin.com>
Date:   Fri, 24 May 2019 08:28:53 +0000
From:   TonyWWang-oc <TonyWWang-oc@...oxin.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "lenb@...nel.org" <lenb@...nel.org>,
        David Wang <DavidWang@...oxin.com>,
        "Cooper Yan(BJ-RD)" <CooperYan@...oxin.com>,
        "Qiyuan Wang(BJ-RD)" <QiyuanWang@...oxin.com>,
        "Herry Yang(BJ-RD)" <HerryYang@...oxin.com>
Subject: 答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

On Thu, May 23, 2019, gregkh@...uxfoundation.org wrote:
>> To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN
>> for system recognition.
>> 
>> Signed-off-by: TonyWWang <TonyWWang-oc@...oxin.com>
>
>Some basic patch tips.  Your From: line needs to match the signed-off-by
>line, which is not true here.  Also, please use your name with ' '
>characters.

Thank you, I will follow these tips. 

>
>> +static void init_zhaoxin_cap(struct cpuinfo_x86 *c)
>> +{
>> +   u32  lo, hi;
>> +
>> +   /* Test for Extended Feature Flags presence */
>> +   if (cpuid_eax(0xC0000000) >= 0xC0000001) {
>> +      u32 tmp = cpuid_edx(0xC0000001);
>
>This patch is totally corrupted, with leading spaces dropped and tabs
>turned into spaces.  Please read the email client documentation in the
>kernel directory for how to fix your email client, or just use 'git
>send-email' to send the patches out directly.

Sorry for that! I  was made a mistake to send the patch with HTML format.
I will set up my email client correctly.

Thanks
TonyWWang-oc