linux-kernel - Re: [PATCH v2] PCI: endpoint: Allocate enough space for fixed size BAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 14:14:47 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Alan Mikhak <alan.mikhak@...ive.com>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lorenzo.pieralisi@....com>,
        <linux-riscv@...ts.infradead.org>,
        Palmer Dabbelt <palmer@...ive.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        <gustavo.pimentel@...opsys.com>, <wen.yang99@....com.cn>,
        <kjlu@....edu>
Subject: Re: [PATCH v2] PCI: endpoint: Allocate enough space for fixed size
 BAR



On 24/05/19 5:26 AM, Alan Mikhak wrote:
> +Bjorn Helgaas, +Gustavo Pimentel, +Wen Yang, +Kangjie Lu
> 
> On Thu, May 23, 2019 at 2:48 PM Alan Mikhak <alan.mikhak@...ive.com> wrote:
>>
>> PCI endpoint test function code should honor the .bar_fixed_size parameter
>> from underlying endpoint controller drivers or results may be unexpected.
>>
>> In pci_epf_test_alloc_space(), check if BAR being used for test register
>> space is a fixed size BAR. If so, allocate the required fixed size.
>>
>> Signed-off-by: Alan Mikhak <alan.mikhak@...ive.com>

Acked-by: Kishon Vijay Abraham I <kishon@...com>
>> ---
>>  drivers/pci/endpoint/functions/pci-epf-test.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
>> index 27806987e93b..7d41e6684b87 100644
>> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
>> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
>> @@ -434,10 +434,16 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
>>         int bar;
>>         enum pci_barno test_reg_bar = epf_test->test_reg_bar;
>>         const struct pci_epc_features *epc_features;
>> +       size_t test_reg_size;
>>
>>         epc_features = epf_test->epc_features;
>>
>> -       base = pci_epf_alloc_space(epf, sizeof(struct pci_epf_test_reg),
>> +       if (epc_features->bar_fixed_size[test_reg_bar])
>> +               test_reg_size = bar_size[test_reg_bar];
>> +       else
>> +               test_reg_size = sizeof(struct pci_epf_test_reg);
>> +
>> +       base = pci_epf_alloc_space(epf, test_reg_size,
>>                                    test_reg_bar, epc_features->align);
>>         if (!base) {
>>                 dev_err(dev, "Failed to allocated register space\n");
>> --
>> 2.7.4
>>