lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 May 2019 07:29:20 -0500 From: Rob Herring <robh@...nel.org> To: Chuanhua Han <chuanhua.han@....com> Cc: Leo Li <leoyang.li@....com>, Shawn Guo <shawnguo@...nel.org>, "mark.rutland@....com" <mark.rutland@....com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ying Zhang <ying.zhang22455@....com> Subject: Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@....com> wrote: > > Hi, Rob Herring > > > -----Original Message----- > > From: Leo Li > > Sent: 2019年5月22日 14:50 > > > > > > > > > - wdog0: watchdog@...0000 { > > > > > > > > > - compatible = "fsl,ls1028a-wdt", > > > > "fsl,imx21-wdt"; > > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > > > > - interrupts = <GIC_SPI 59 > > > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > > > - clocks = <&clockgen 4 1>; > > > > > > > > > - big-endian; > > > > > > > > > - status = "disabled"; > > > > > > > > > + cluster1_core0_watchdog: wdt@...0000 { > > > > > > > > > > > > > > > > Keep 'watchdog' as the node name, > > > > > > > Thanks for your replay > > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > > > > and keep nodes sort in unit-address. > > > > > > > What does this mean? > > > > > > > > > > > > That means order the nodes by the addresses (e.g. c000000, > > > > > > c010000) > > > > > The current order is correct(The first is c000000, then c000000). > > > > > > > > But they are added after gpio@...0000 and before sata@...0000. > > > I changed and made the second version of the patch, but I found the > > > following error when I executed ./scripts/checkpatch.pl xxx.patch to > > > check the patch: > > > > > > WARNING: DT compatible string vendor "arm" appears un-documented -- > > > check ./Documentation/devicetree/bindings/vendor-prefixes.txt > > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > However, there is no vendor-prefixes.txt file in the > > > ./Documentation/devicetree/bindings/ directory, only vendor- > > > prefixes.yaml. > > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. > > > > Added Rob Herring to the thread. > > > > > Request help,thanks > How can I solve this patch check error? Ask for help, thank you! Ignore it. A fix to checkpatch.pl is pending. Rob
Powered by blists - more mailing lists