linux-kernel - Re: [PATCH] signal: reorder struct sighand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190523191115.66a4d57dc0ae991415fa131e@linux-foundation.org>
Date:   Thu, 23 May 2019 19:11:15 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH] signal: reorder struct sighand_struct

On Sat, 4 May 2019 19:33:02 -0400 Michal Hocko <mhocko@...nel.org> wrote:

> CCing Oleg.
> 
> On Fri 03-05-19 22:28:00, Alexey Dobriyan wrote:
> [...]
> > add/remove: 0/0 grow/shrink: 8/68 up/down: 49/-1147 (-1098)
> [...]
> > --- a/include/linux/sched/signal.h
> > +++ b/include/linux/sched/signal.h
> > @@ -15,10 +15,10 @@
> >   */
> >  
> >  struct sighand_struct {
> > -	refcount_t		count;
> > -	struct k_sigaction	action[_NSIG];
> >  	spinlock_t		siglock;
> > +	refcount_t		count;
> >  	wait_queue_head_t	signalfd_wqh;
> > +	struct k_sigaction	action[_NSIG];
> >  };
> 
> Is it possible that this would cause false sharing of the cache line
> that would have performance implications now?

Doesn't seem likely.  Possible .count vs .siglock, but .count only gets
altered by fork/exec-style code, so it's pretty low bandwidth.