linux-kernel - Re: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to CTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <049648ab-0e51-c079-b7c8-c9022cae20b4@huawei.com>
Date:   Sat, 25 May 2019 17:00:03 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Eric Dumazet <edumazet@...gle.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to
 CTL_ULONG


On 2019/5/24 23:00, Eric Dumazet wrote:
> On Fri, May 24, 2019 at 7:30 AM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"),
>> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG
>> instead of CTL_INT to keep consistent.
>
> What about  compatibility with existing applications ?
> Will there sysctl() fail if they provide 32bit variable ?
>
> /proc/sys/net  files are text files, but sysctl() system call has been
> discouraged for more than a decade.

The sysctl() system call is deprecated, so the main purpose of this patch is to keep consistent,

but it does set wrong value(eg, set 16000000000 to ipfrag_high_thresh) when use sysctl().


>
>