lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 May 2019 13:40:52 +0200 From: Alexandre Belloni <alexandre.belloni@...tlin.com> To: Hariprasad Kelam <hariprasad.kelam@...il.com> Cc: Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rtc: ds1347: fix warning PTR_ERR_OR_ZERO can be used Hi, On 25/05/2019 15:23:22+0530, Hariprasad Kelam wrote: > fix below warning reported by coccicheck > > ./drivers/rtc/rtc-ds1347.c:158:1-3: WARNING: PTR_ERR_OR_ZERO can be used > Could you elaborate on what is the exact improvement? > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com> > --- > drivers/rtc/rtc-ds1347.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c > index 938512c..b97b67f 100644 > --- a/drivers/rtc/rtc-ds1347.c > +++ b/drivers/rtc/rtc-ds1347.c > @@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi) > rtc = devm_rtc_device_register(&spi->dev, "ds1347", > &ds1347_rtc_ops, THIS_MODULE); > > - if (IS_ERR(rtc)) > - return PTR_ERR(rtc); > - > - return 0; > + return PTR_ERR_OR_ZERO(rtc); > } > > static struct spi_driver ds1347_driver = { > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Powered by blists - more mailing lists