lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 May 2019 00:08:46 +0100 From: Al Viro <viro@...iv.linux.org.uk> To: David Howells <dhowells@...hat.com> Cc: trond.myklebust@...merspace.com, anna.schumaker@...app.com, linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 23/23] NFS: Add fs_context support. On Thu, May 23, 2019 at 05:19:05PM +0100, David Howells wrote: > out_no_data: > - dfprintk(MOUNT, "NFS: mount program didn't pass any mount data\n"); > - return -EINVAL; > + if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) { > + ctx->skip_reconfig_option_check = true; > + return 0; > + } That really ought to be if (fc->root) { /* remount */ ctx->skip_reconfig_option_check = true; return 0; } and similar in the v4 counterpart. fc->purpose is a bad idea; it is possible to get rid of it. Frankly, I'm tempted to add static inline bool is_remount_fc(struct fs_context *fc) { return fc->root != NULL; } and just use that in such places...
Powered by blists - more mailing lists