lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 May 2019 23:32:35 -0400
From:   Steven Rostedt <>
        linux-rt-users <>
Cc:     Thomas Gleixner <>,
        Carsten Emde <>,
        Sebastian Andrzej Siewior <>,
        John Kacur <>,
        Paul Gortmaker <>,
        Julia Cartwright <>,
        Daniel Wagner <>,, Julien Grall <>,
        Greg Kroah-Hartman <>,
Subject: [PATCH RT 3/6] tty/sysrq: Convert show_lock to raw_spinlock_t

4.19.37-rt20-rc1 stable review patch.
If anyone has any objections, please let me know.


From: Julien Grall <>

Systems which don't provide arch_trigger_cpumask_backtrace() will
invoke showacpu() from a smp_call_function() function which is invoked
with disabled interrupts even on -RT systems.

The function acquires the show_lock lock which only purpose is to
ensure that the CPUs don't print simultaneously. Otherwise the
output would clash and it would be hard to tell the output from CPUx
apart from CPUy.

On -RT the spin_lock() can not be acquired from this context. A
raw_spin_lock() is required. It will introduce the system's latency
by performing the sysrq request and other CPUs will block on the lock
until the request is done. This is okay because the user asked for a
backtrace of all active CPUs and under "normal circumstances in
production" this path should not be triggered.

Signed-off-by: Julien Grall <>
Signed-off-by: Steven Rostedt (VMware) <>
[ commit description]
Signed-off-by: Sebastian Andrzej Siewior <>
Acked-by: Sebastian Andrzej Siewior <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Sebastian Andrzej Siewior <>
 drivers/tty/sysrq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 06ed20dd01ba..627517ad55bf 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -215,7 +215,7 @@ static struct sysrq_key_op sysrq_showlocks_op = {
 #ifdef CONFIG_SMP
-static DEFINE_SPINLOCK(show_lock);
+static DEFINE_RAW_SPINLOCK(show_lock);
 static void showacpu(void *dummy)
@@ -225,10 +225,10 @@ static void showacpu(void *dummy)
 	if (idle_cpu(smp_processor_id()))
-	spin_lock_irqsave(&show_lock, flags);
+	raw_spin_lock_irqsave(&show_lock, flags);
 	pr_info("CPU%d:\n", smp_processor_id());
 	show_stack(NULL, NULL);
-	spin_unlock_irqrestore(&show_lock, flags);
+	raw_spin_unlock_irqrestore(&show_lock, flags);
 static void sysrq_showregs_othercpus(struct work_struct *dummy)

Powered by blists - more mailing lists