lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 25 May 2019 08:24:43 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Colin King" <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ASoC: cx2072x: remove redundant assignment to pulse_len

On Fri, 24 May 2019 23:44:19 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable pulse_len is being initialized to 1 however this value is
> never read and pulse_len is being re-assigned later in a switch
> statement.  Clean up the code by removing the redundant initialization.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi

Powered by blists - more mailing lists