[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <8b879ef19e5dd7520ac80c3f93c47ff63a8e1b6e.1558832514.git.gneukum1@gmail.com>
Date: Sun, 26 May 2019 01:18:32 +0000
From: Geordan Neukum <gneukum1@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
Geordan Neukum <gneukum1@...il.com>
Subject: [PATCH 6/8] staging: kpc2000: kpc_i2c: fail probe if unable to get I/O resource
The kpc_i2c driver attempts to map its I/O space without verifying
whether or not the result of platform_get_resource() is NULL. Make the
driver check that platform_get_resource did not return NULL before
attempting to use the value returned to map an I/O space.
Signed-off-by: Geordan Neukum <gneukum1@...il.com>
---
drivers/staging/kpc2000/kpc2000_i2c.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index e4bbb91af972..452052bf9476 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -587,6 +587,9 @@ static int pi2c_probe(struct platform_device *pldev)
priv->adapter.algo = &smbus_algorithm;
res = platform_get_resource(pldev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -ENXIO;
+
priv->smba = (unsigned long)ioremap_nocache(res->start, resource_size(res));
platform_set_drvdata(pldev, priv);
--
2.21.0
Powered by blists - more mailing lists