lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 26 May 2019 19:11:34 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, bgolaszewski@...libre.com,
        pavel@....cz, dmurphy@...com
Cc:     linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH -next] leds: max77650: Remove set but not used variable
 'parent'

Hi YueHaibing,

Thank you for the patch.

On 5/25/19 4:19 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/leds/leds-max77650.c: In function max77650_led_probe:
> drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable]
> 
> It is never used and can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/leds/leds-max77650.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
> index 6b74ce9cac12..8a8e5c65b157 100644
> --- a/drivers/leds/leds-max77650.c
> +++ b/drivers/leds/leds-max77650.c
> @@ -64,7 +64,6 @@ static int max77650_led_probe(struct platform_device *pdev)
>   {
>   	struct device_node *of_node, *child;
>   	struct max77650_led *leds, *led;
> -	struct device *parent;
>   	struct device *dev;
>   	struct regmap *map;
>   	const char *label;
> @@ -72,7 +71,6 @@ static int max77650_led_probe(struct platform_device *pdev)
>   	u32 reg;
>   
>   	dev = &pdev->dev;
> -	parent = dev->parent;
>   	of_node = dev->of_node;
>   
>   	if (!of_node)
> 

Applied.

-- 
Best regards,
Jacek Anaszewski

Powered by blists - more mailing lists