linux-kernel - Re: [Qemu-devel] Running linux on qemu omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05bd307b-c8c5-4b12-be45-2d7933876aac@redhat.com>
Date:   Mon, 27 May 2019 08:30:34 +0200
From:   Thomas Huth <thuth@...hat.com>
To:     Aaro Koskinen <aaro.koskinen@....fi>,
        Peter Maydell <peter.maydell@...aro.org>
Cc:     Philippe Mathieu-Daudé <philmd@...hat.com>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        QEMU Developers <qemu-devel@...gnu.org>,
        lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [Qemu-devel] Running linux on qemu omap

On 24/05/2019 20.59, Aaro Koskinen wrote:
> Hi,
> 
> On Fri, May 24, 2019 at 06:00:18PM +0300, Aaro Koskinen wrote:
>> Please don't delete OMAP boards quite yet :) In the mainline kernel
>> they are not orphaned, they frequently get tested using actual hardware,
>> and QEMU would help in additional testing. I'll try to get N8x0 boot to
>> work with the minimal kernel I use on real HW.
> 
> So it was only a matter of attaching the serial console at the QEMU side
> (a hackish patch at the end of the mail).

Does not look too much hackish to me. Could you please send it as a
proper patch to the list (with patch description and Signed-off-by line)?

 Thomas


> 
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 906b7ca22d43..52ff83ec5147 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -792,6 +792,7 @@ static void n8x0_uart_setup(struct n800_s *s)
>      qdev_connect_gpio_out(s->mpu->gpio, N8X0_BT_WKUP_GPIO,
>                      csrhci_pins_get(radio)[csrhci_pin_wakeup]);
>  
> +    omap_uart_attach(s->mpu->uart[2], serial_hd(0));
>      omap_uart_attach(s->mpu->uart[BT_UART], radio);
>  }
>  
>