linux-kernel - Re: [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile_lcdc_display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190527065246.GB8648@ravnborg.org>
Date:   Mon, 27 May 2019 08:52:46 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        DRI Development <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 11/33] fbdev/sh_mobile: remove
 sh_mobile_lcdc_display_notify

On Mon, May 27, 2019 at 08:13:06AM +0200, Daniel Vetter wrote:
> On Sat, May 25, 2019 at 05:01:59PM +0200, Sam Ravnborg wrote:
> > Hi Daniel
> > 
> > > It's dead code, and removing it avoids me having to understand
> > > what it's doing with lock_fb_info.
> > 
> > I pushed the series through my build tests which include the sh
> > architecture.
> > 
> > One error and one warning was triggered from sh_mobile_lcdcfb.c.
> > The rest was fine.
> > 
> > The patch below removed the sole user of
> > sh_mobile_lcdc_must_reconfigure() so this triggers a warning.
> > 
> > And I also get the following error:
> > drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_fb_reconfig’:
> > drivers/video/fbdev/sh_mobile_lcdcfb.c:1800:2: error: implicit declaration of function ‘fbcon_update_vcs’; did you mean ‘file_update_time’? [-Werror=implicit-function-declaration]
> >   fbcon_update_vcs(info, true);
> >   ^~~~~~~~~~~~~~~~
> >   file_update_time
> > 
> > I did not check but assume the error was triggered in patch 28 where
> > fbcon_update_vcs() in introduced.
> 
> Oops. Can I have your sob so I can squash this in?
Yes, here we go. (It was trivial so I thought not needed, sorry)
Signed-off-by: Sam Ravnborg <sam@...nborg.org>