linux-kernel - Re: [PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7eac9wki.wl-tiwai@suse.de>
Date:   Mon, 27 May 2019 09:38:05 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right_j '

On Sat, 25 May 2019 14:32:04 +0200,
YueHaibing wrote:
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm:
> sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable]
> 
> It's never used and can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi


> ---
>  sound/soc/codecs/cx2072x.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c
> index 23d2b25fe04c..a066ef83de1a 100644
> --- a/sound/soc/codecs/cx2072x.c
> +++ b/sound/soc/codecs/cx2072x.c
> @@ -676,7 +676,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
>  	unsigned int bclk_rate = 0;
>  	int is_i2s = 0;
>  	int has_one_bit_delay = 0;
> -	int is_right_j = 0;
>  	int is_frame_inv = 0;
>  	int is_bclk_inv = 0;
>  	int pulse_len = 1;
> @@ -740,7 +739,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
>  
>  	case SND_SOC_DAIFMT_RIGHT_J:
>  		is_i2s = 1;
> -		is_right_j = 1;
>  		pulse_len = frame_len / 2;
>  		break;
>  
> -- 
> 2.17.1
> 
> 
>