linux-kernel - Re: [PATCH] drm/omapdrm: fix warning PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f72e575-82b6-0dc0-ec36-1e21d355c9f0@ti.com>
Date:   Mon, 27 May 2019 12:06:53 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Matteo Croce <mcroce@...hat.com>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>
CC:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/omapdrm: fix warning PTR_ERR_OR_ZERO can be used

Hi,

On 25/05/2019 17:56, Matteo Croce wrote:
> On Sat, May 25, 2019 at 9:30 AM Hariprasad Kelam
> <hariprasad.kelam@...il.com> wrote:
>>
>> fix below warnings reported by coccicheck
>>
> 
> Hi,
> 
> a similar patch was nacked because it makes backports more difficult:
> 
> https://lore.kernel.org/lkml/3dec4093-824e-b13d-d712-2dedd445a7b7@ti.com/
> 
> Tomi, what's your thought?
> 

I don't particularly like the PTR_ERR_OR_ZERO, and changing old code to 
use it seem pointless.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki