linux-kernel - Re: [PATCH v1 2/2] drm/stm: dsi: add power on/off phy ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24c1ee24-af80-8605-d042-76a43c985068@st.com>
Date:   Mon, 27 May 2019 12:54:37 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Heiko Stuebner" <heiko@...ech.de>,
        Sam Ravnborg <sam@...nborg.org>,
        Nickey Yang <nickey.yang@...k-chips.com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent ABRIOU <vincent.abriou@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] drm/stm: dsi: add power on/off phy ops

Hi Yannick,
and thank you for your patch.

Tested successfully on stm32f too.

Acked-by: Philippe Cornu <philippe.cornu@...com>
Tested-by: Philippe Cornu <philippe.cornu@...com>

Philippe :-)

On 5/27/19 12:21 PM, Yannick Fertré wrote:
> These new physical operations are helpful to power_on/off the dsi
> wrapper. If the dsi wrapper is powered in video mode, the display
> controller (ltdc) register access will hang when DSI fifos are full.
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
> ---
>   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 01db020..0ab32fe 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -210,10 +210,27 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
>   	if (ret)
>   		DRM_DEBUG_DRIVER("!TIMEOUT! waiting PLL, let's continue\n");
>   
> +	return 0;
> +}
> +
> +static void dw_mipi_dsi_phy_power_on(void *priv_data)
> +{
> +	struct dw_mipi_dsi_stm *dsi = priv_data;
> +
> +	DRM_DEBUG_DRIVER("\n");
> +
>   	/* Enable the DSI wrapper */
>   	dsi_set(dsi, DSI_WCR, WCR_DSIEN);
> +}
>   
> -	return 0;
> +static void dw_mipi_dsi_phy_power_off(void *priv_data)
> +{
> +	struct dw_mipi_dsi_stm *dsi = priv_data;
> +
> +	DRM_DEBUG_DRIVER("\n");
> +
> +	/* Disable the DSI wrapper */
> +	dsi_clear(dsi, DSI_WCR, WCR_DSIEN);
>   }
>   
>   static int
> @@ -287,6 +304,8 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
>   
>   static const struct dw_mipi_dsi_phy_ops dw_mipi_dsi_stm_phy_ops = {
>   	.init = dw_mipi_dsi_phy_init,
> +	.power_on = dw_mipi_dsi_phy_power_on,
> +	.power_off = dw_mipi_dsi_phy_power_off,
>   	.get_lane_mbps = dw_mipi_dsi_get_lane_mbps,
>   };
>   
>