linux-kernel - Re: [PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 May 2019 16:27:36 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Kosina <trivial@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [trivial] perf: Spelling s/EACCESS/EACCES/

Hi Ingo,

On Mon, May 27, 2019 at 4:12 PM Ingo Molnar <mingo@...nel.org> wrote:
> * Geert Uytterhoeven <geert+renesas@...der.be> wrote:
> > The correct spelling is EACCES:
> >
> > include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -289,7 +289,7 @@ struct pmu {
> >        *  -EBUSY      -- @event is for this PMU but PMU temporarily unavailable
> >        *  -EINVAL     -- @event is for this PMU but @event is not valid
> >        *  -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
> > -      *  -EACCESS    -- @event is for this PMU, @event is valid, but no privilidges
> > +      *  -EACCES     -- @event is for this PMU, @event is valid, but no privilidges
> >        *
> >        *  0           -- @event is for this PMU and valid
> >        *
>
>
> Actually, -EACCES got typoed itself and survived due to historic reasons.

Quite possible... Someone pointed out a while ago it is part of POSIX,
hence it cannot be changed.

Probably we can do "#define EACCESS EACCES"?

> I think we can tolerate the 'typo' fixed in documentation, can we?

IMHO we cannot, as e.g. "git grep -w" won't match both.
Do you really want the documentation to differ from the implementation?

> Also, the *far* bigger typo is, in the same line:
>
> s/privilidges
>  /privileges

Thanks, that one didn't show up with "git grep -w EACCESS" ;-)
Will send v2...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds