linux-kernel - [PATCH -next] memory: emif: Remove set but not used variables 'custom_configs' and 'cs1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 27 May 2019 23:45:25 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <ssantosh@...nel.org>, <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>, YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH -next] memory: emif: Remove set but not used variables 'custom_configs' and 'cs1_used'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/memory/emif.c: In function get_emif_reg_values:
drivers/memory/emif.c:1626:36: warning: variable custom_configs set but not used [-Wunused-but-set-variable]
drivers/memory/emif.c: In function get_emif_reg_values:
drivers/memory/emif.c:1618:9: warning: variable cs1_used set but not used [-Wunused-but-set-variable]

They are not used since introduction in commit
a93de288aad3 ("memory: emif: handle frequency and voltage change events")

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/memory/emif.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 2f214440008c..1b262bbd1d65 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -1615,7 +1615,7 @@ static void emif_shutdown(struct platform_device *pdev)
 static int get_emif_reg_values(struct emif_data *emif, u32 freq,
 		struct emif_regs *regs)
 {
-	u32				cs1_used, ip_rev, phy_type;
+	u32				ip_rev, phy_type;
 	u32				cl, type;
 	const struct lpddr2_timings	*timings;
 	const struct lpddr2_min_tck	*min_tck;
@@ -1623,7 +1623,6 @@ static int get_emif_reg_values(struct emif_data *emif, u32 freq,
 	const struct lpddr2_addressing	*addressing;
 	struct emif_data		*emif_for_calc;
 	struct device			*dev;
-	const struct emif_custom_configs *custom_configs;
 
 	dev = emif->dev;
 	/*
@@ -1641,12 +1640,10 @@ static int get_emif_reg_values(struct emif_data *emif, u32 freq,
 
 	device_info	= emif_for_calc->plat_data->device_info;
 	type		= device_info->type;
-	cs1_used	= device_info->cs1_used;
 	ip_rev		= emif_for_calc->plat_data->ip_rev;
 	phy_type	= emif_for_calc->plat_data->phy_type;
 
 	min_tck		= emif_for_calc->plat_data->min_tck;
-	custom_configs	= emif_for_calc->plat_data->custom_configs;
 
 	set_ddr_clk_period(freq);
 
-- 
2.17.1