linux-kernel - Re: [PATCH v4] crypto: caam - strip input without changing crypto request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 May 2019 16:30:22 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v4] crypto: caam - strip input without changing crypto
 request

On 5/24/2019 5:47 PM, Iuliana Prodan wrote:
> For rsa and pkcs1pad, CAAM expects an input of modulus size.
> For this we strip the leading zeros in case the size is more than modulus.
> This commit avoids modifying the crypto request while stripping zeros from
> input, to comply with the crypto API requirement. This is done by adding
> a fixup input pointer and length.
> 
> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
> ---
> Changes since V3:
> 	- no changes.
Since there were no changes, you should have kept the Reviewed-by tag I provided
for v3.

Another thing: don't send a patch set with
[PATCH v3 1/2]
[PATCH v4]

It's confusing:
-patches belonging to a patch set should have the same version / prefix
-makes one think patches are missing (where is 2/2?)

Thanks,
Horia