linux-kernel - Re: [RFC PATCH 2/6] cpumask: Purify cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5EE58FF7-FDAA-4C4E-8A61-B8BECC29CDD3@vmware.com>
Date:   Mon, 27 May 2019 17:34:26 +0000
From:   Nadav Amit <namit@...are.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Ingo Molnar <mingo@...hat.com>, Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC PATCH 2/6] cpumask: Purify cpumask_next()

> On May 27, 2019, at 1:30 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> 
> On Sat, May 25, 2019 at 01:21:59AM -0700, Nadav Amit wrote:
>> cpumask_next() has no side-effects. Mark it as pure.
> 
> It would be good to have a few word on why... because apparently you
> found this makes a difference.

I see that eventually it did not make any difference. I saw in the past that
some instances of the kernel are affected by it, but I will remove it from
this patch-set in the next iteration.