linux-kernel - Re: [PATCH -next] IB/hfi1: remove set but not used variables 'offset' and 'fspsn'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190527231008.GA19493@ziepe.ca>
Date:   Mon, 27 May 2019 20:10:08 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     mike.marciniszyn@...el.com, dennis.dalessandro@...el.com,
        dledford@...hat.com, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH -next] IB/hfi1: remove set but not used variables
 'offset' and 'fspsn'

On Sat, May 25, 2019 at 08:57:37PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/infiniband/hw/hfi1/tid_rdma.c: In function tid_rdma_rcv_error:
> drivers/infiniband/hw/hfi1/tid_rdma.c:2029:7: warning: variable offset set but not used [-Wunused-but-set-variable]
> drivers/infiniband/hw/hfi1/tid_rdma.c: In function hfi1_rc_rcv_tid_rdma_ack:
> drivers/infiniband/hw/hfi1/tid_rdma.c:4555:35: warning: variable fspsn set but not used [-Wunused-but-set-variable]
> 
> 'offset' is never used since introduction in
> commit d0d564a1caac ("IB/hfi1: Add functions to receive TID RDMA READ request")
> 
> 'fspsn' is never used since introduciotn in
> commit 9e93e967f7b4 ("IB/hfi1: Add a function to receive TID RDMA ACK packet")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/infiniband/hw/hfi1/tid_rdma.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied to for-next

Thanks,
Jason