linux-kernel - Re: [Patch] perf stat: always separate stalled cycles per insn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528191102.GD13830@kernel.org>
Date:   Tue, 28 May 2019 16:11:02 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [Patch] perf stat: always separate stalled cycles per insn

Em Tue, May 28, 2019 at 11:21:38AM -0700, Cong Wang escreveu:
> On Sun, May 19, 2019 at 11:59 PM Jiri Olsa <jolsa@...hat.com> wrote:
> >
> > On Fri, May 17, 2019 at 03:10:39PM -0700, Cong Wang wrote:
> > > The "stalled cycles per insn" is appended to "instructions" when
> > > the CPU has this hardware counter directly. We should always make it
> > > a separate line, which also aligns to the output when we hit the
> > > "if (total && avg)" branch.
> > >
> > > Before:
> > > $ sudo perf stat --all-cpus --field-separator , --log-fd 1 -einstructions,cycles -- sleep 1
> > > 4565048704,,instructions,64114578096,100.00,1.34,insn per cycle,,
> > > 3396325133,,cycles,64146628546,100.00,,
> > >
> > > After:
> > > $ sudo ./tools/perf/perf stat --all-cpus --field-separator , --log-fd 1 -einstructions,cycles -- sleep 1
> > > 6721924,,instructions,24026790339,100.00,0.22,insn per cycle
> > > ,,,,,0.00,stalled cycles per insn
> > > 30939953,,cycles,24025512526,100.00,,
> > >
> > > Cc: Andi Kleen <ak@...ux.intel.com>
> > > Cc: Jiri Olsa <jolsa@...nel.org>
> > > Cc: Ingo Molnar <mingo@...hat.com>
> > > Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> > > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> >
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Thanks for reviewing it. Is there anyone takes this patch?

Enough time, acked already, picking it.

- Arnaldo