linux-kernel - Question about padata's callback cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528233707.gc4xomnlcuiszqht@ca-dmjordan1.us.oracle.com>
Date:   Tue, 28 May 2019 19:37:07 -0400
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     steffen.klassert@...unet.com
Cc:     peterz@...radead.org, akpm@...ux-foundation.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Question about padata's callback cpu

Hi Steffen,

I'm working on some padata patches and stumbled across this thread about the
purpose of the callback CPU in padata_do_parallel.

    https://lore.kernel.org/lkml/20100402112326.GA19502@secunet.com/

The relevant part is,

  andrew> - Why would I want to specify which CPU the parallel completion
  andrew>   callback is to be executed on?

    steffen> Well, for IPsec for example it is quite interesting to separate the
    steffen> different flows to different cpus. pcrypt does this by choosing different
    steffen> callback cpus for the requests belonging to different transforms.
    steffen> Others might want to see the object on the same cpu as it was before
    steffen> the parallel codepath.

Not too familiar with IPsec, but I'm guessing it's interesting to separate the
flows for performance reasons.  Is the goal to keep multiple flows from
interfering with each other (ensuring they run on different CPUs), or maybe to
get better locality (ensuring each always runs on the same CPU)?  It'd be
helpful if you could expand on this.

By the way, the padata patches extend the code to parallelize more places
around the kernel, as Peter suggested.

    https://lore.kernel.org/lkml/20181106203411.pdce6tgs7dncwflh@ca-dmjordan1.us.oracle.com/

Thanks,
Daniel