linux-kernel - Re: [PATCH 0/5] firmware: Add support for loading compressed files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5himtv8821.wl-tiwai@suse.de>
Date:   Tue, 28 May 2019 07:25:10 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] firmware: Add support for loading compressed files

On Mon, 20 May 2019 11:26:42 +0200,
Takashi Iwai wrote:
> 
> Hi,
> 
> this is a patch set to add the support for loading compressed firmware
> files.
> 
> The primary motivation is to reduce the storage size; e.g. currently
> the amount of /lib/firmware on my machine counts up to 419MB, and this
> can be reduced to 130MB file compression.  No bad deal.
> 
> The feature adds only fallback to the compressed file, so it should
> work as it was as long as the normal firmware file is present.  The
> f/w loader decompresses the content, so that there is no change needed
> in the caller side.
> 
> Currently only XZ format is supported.  A caveat is that the kernel XZ
> helper code supports only CRC32 (or none) integrity check type, so
> you'll have to compress the files via xz -C crc32 option.
> 
> The patch set begins with a few other improvements and refactoring,
> followed by the compression support.
> 
> In addition to this, dracut needs a small fix to deal with the *.xz
> files.
> 
> Also, the latest patchset is found in topic/fw-decompress branch of my
> sound.git tree:
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> 
> 
> thanks,
> 
> Takashi

Luis, any comments on the patchset?


thanks,

Takashi

> 
> ===
> 
> Takashi Iwai (5):
>   firmware: Free temporary page table after vmapping
>   firmware: Unify the paged buffer release helper
>   firmware: Use kvmalloc for page tables
>   firmware: Factor out the paged buffer handling code
>   firmware: Add support for loading compressed files
> 
>  drivers/base/firmware_loader/Kconfig    |  18 +++
>  drivers/base/firmware_loader/fallback.c |  63 ++--------
>  drivers/base/firmware_loader/firmware.h |  16 ++-
>  drivers/base/firmware_loader/main.c     | 212 +++++++++++++++++++++++++++++---
>  4 files changed, 235 insertions(+), 74 deletions(-)
> 
> -- 
> 2.16.4
>