linux-kernel - Re: [PATCH 2/3] KVM: X86: Implement PV sched yield hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CxEa2Z1Ob=pEM03AvryHUfjg-MEc75w5_a-wHzrb9NtvQ@mail.gmail.com>
Date:   Tue, 28 May 2019 08:54:14 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH 2/3] KVM: X86: Implement PV sched yield hypercall

On Mon, 27 May 2019 at 19:54, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 27/05/19 12:34, Wanpeng Li wrote:
> > +     rcu_read_lock();
> > +     map = rcu_dereference(kvm->arch.apic_map);
> > +     target = map->phys_map[dest_id]->vcpu;
> > +     rcu_read_unlock();
> > +
> > +     kvm_vcpu_yield_to(target);
>
> This needs to check that map->phys_map[dest_id] is not NULL.

Fixed in v2, thanks for the quick review. :)

Regards,
Wanpeng Li