linux-kernel - Re: [PATCH] usb: typec: ucsi: ccg: fix memory leak in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528080452.GB7167@kuha.fi.intel.com>
Date:   Tue, 28 May 2019 11:04:52 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ajay Gupta <ajayg@...dia.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: ccg: fix memory leak in do_flash

On Mon, May 27, 2019 at 01:10:50PM -0500, Gustavo A. R. Silva wrote:
> In case memory resources for *fw* were successfully allocated,
> release them before return.
> 
> Addresses-Coverity-ID: 1445499 ("Resource leak")
> Fixes: 5c9ae5a87573 ("usb: typec: ucsi: ccg: add firmware flashing support")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...il.com>

> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 9d46aa9e4e35..bf63074675fc 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -862,8 +862,10 @@ static int do_flash(struct ucsi_ccg *uc, enum enum_flash_mode mode)
>  
>  not_signed_fw:
>  	wr_buf = kzalloc(CCG4_ROW_SIZE + 4, GFP_KERNEL);
> -	if (!wr_buf)
> -		return -ENOMEM;
> +	if (!wr_buf) {
> +		err = -ENOMEM;
> +		goto release_fw;
> +	}
>  
>  	err = ccg_cmd_enter_flashing(uc);
>  	if (err)
> -- 
> 2.21.0

thanks,

-- 
heikki