linux-kernel - Re: [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11be5350-23db-6216-3c2b-1d8b161cac9b@yandex-team.ru>
Date:   Tue, 28 May 2019 11:38:33 +0300
From:   Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
To:     Nicolas Boichat <drinkcat@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Marc Zyngier <marc.zyngier@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/decode_stacktrace: Look for modules with
 .ko.debug extension

On 22.05.2019 2:41, Nicolas Boichat wrote:
> In Chromium OS kernel builds, we split the debug information as
> .ko.debug files, and that's what decode_stacktrace.sh needs to use.
> 
> Relax objfile matching rule to allow any .ko* file to be matched.
> 
> Signed-off-by: Nicolas Boichat <drinkcat@...omium.org>
> ---
>   scripts/decode_stacktrace.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index bcdd45df3f5127a..c851c1eb16f9cf7 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
>   		local objfile=${modcache[$module]}
>   	else
>   		[[ $modpath == "" ]] && return
> -		local objfile=$(find "$modpath" -name $module.ko -print -quit)
> +		local objfile=$(find "$modpath" -name $module.ko* -print -quit)

Ok but should be quoted "$module.ko*" or escaped $module.ko\*

>   		[[ $objfile == "" ]] && return
>   		modcache[$module]=$objfile
>   	fi
>