linux-kernel - Re: [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d3160d2-ce36-980a-1054-03bdece5bbfc@gmail.com>
Date:   Tue, 28 May 2019 13:10:42 +0300
From:   Oleksandr <olekstysh@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Julien Grall <julien.grall@....com>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Subject: Re: [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI
 is available


On 28.05.19 11:27, Geert Uytterhoeven wrote:
> Hi Oleksandr,

Hi Geert, all


> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thank you for review!


Just FYI:

Required support for Gen2 Stout board has been already added to Xen [1].

What needs to be done next is to add support for handling device-tree 
nodes with "interrupts-extended" property in Xen [2].
This is related to Gen3 as well.


[1] 
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg44386.html

[2] 
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg45951.html

>
> Two cosmetic comments below. I'll leave it to Simon to ignore them for
> applying ;-)
>
>> @@ -62,6 +63,21 @@ void __init rcar_gen2_timer_init(void)
>>   {
>>          void __iomem *base;
>>          u32 freq;
>> +       bool need_update = true;
> Some people like reverse Xmas tree declaration order...
>
>> +
>> +       /*
>> +        * If PSCI is available then most likely we are running on PSCI-enabled
>> +        * U-Boot which, we assume, has already taken care of resetting CNTVOFF
>> +        * and updating counter module before switching to non-secure mode
>> +        * and we don't need to.
>> +        */
>> +#if defined(CONFIG_ARM_PSCI_FW)
> #ifdef CONFIG_ARM_PSCI_FW ?
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
-- 
Regards,

Oleksandr Tyshchenko