linux-kernel - Re: [PATCH 2/7] sched/fair: Replace source_load() & target_load() w/ weighted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 May 2019 12:53:12 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Hillf Danton <hdanton@...a.com>, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Rik van Riel <riel@...riel.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Morten Rasmussen <morten.rasmussen@....com>,
        Quentin Perret <quentin.perret@....com>,
        Valentin Schneider <valentin.schneider@....com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] sched/fair: Replace source_load() & target_load() w/
 weighted_cpuload()

On Tue, May 28, 2019 at 12:24:52PM +0200, Dietmar Eggemann wrote:
> On 5/28/19 6:42 AM, Hillf Danton wrote:
> > 
> > On Mon, 27 May 2019 07:21:11 +0100 Dietmar Eggemann wrote:
> 
> [...]
> 
> > > @@ -5500,7 +5464,7 @@ wake_affine_weight(struct sched_domain *sd, struct task_struct *p,
> > >   		this_eff_load *= 100;
> > >   	this_eff_load *= capacity_of(prev_cpu);
> > > -	prev_eff_load = source_load(prev_cpu, sd->wake_idx);
> > > +	prev_eff_load = weighted_cpuload(cpu_rq(this_cpu));
> > 					 cpu_rq(prev_cpu)
> > 
> > Seems we have no need to see this cpu's load more than once.
> 
> Thanks for catching this! Will fix it in v2.

Fixed :-)