linux-kernel - Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 May 2019 12:13:08 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:     <wsa@...-dreams.de>, <jarkko.nikula@...ux.intel.com>,
        <andriy.shevchenko@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <benjamin.tissoires@...hat.com>, <jbroadus@...il.com>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions

On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote:
> On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote:
> >  static int i2c_acpi_get_info(struct acpi_device *adev,
> >  			     struct i2c_board_info *info,
> >  			     struct i2c_adapter *adapter,
> >  			     acpi_handle *adapter_handle)
> >  {
> >  	struct list_head resource_list;
> > -	struct resource_entry *entry;
> >  	struct i2c_acpi_lookup lookup;
> > +	int irq = -ENOENT;
> >  	int ret;
> >  
> >  	memset(&lookup, 0, sizeof(lookup));
> > @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
> >  
> >  	/* Then fill IRQ number if any */
> >  	INIT_LIST_HEAD(&resource_list);
> > -	ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
> > +	ret = acpi_dev_get_resources(adev, &resource_list,
> > +				     i2c_acpi_add_resource, &irq);
> >  	if (ret < 0)
> >  		return -EINVAL;
> >  
> > -	resource_list_for_each_entry(entry, &resource_list) {
> > -		if (resource_type(entry->res) == IORESOURCE_IRQ) {
> > -			info->irq = entry->res->start;
> > -			break;
> > -		}
> > -	}
> > +	if (irq >= 0)
> 
> Since 0 is not valid IRQ, I think this should be written like:
> 
> 	if (irg > 0)
> 

Yeah sorry thought IRQs were like GPIOs where 0 is a valid
number, will update the patches.

Thanks,
Charles
> > +		info->irq = irq;
> >  
> >  	acpi_dev_free_resource_list(&resource_list);
> >  
> > -- 
> > 2.11.0