linux-kernel - Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a2361a08a0b8a1be1e2f5921026661f@www.akkea.ca>
Date:   Tue, 28 May 2019 06:00:19 -0700
From:   Angus Ainslie <angus@...ea.ca>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     angus.ainslie@...i.sm, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Abel Vesa <abel.vesa@....com>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Carlo Caione <ccaione@...libre.com>,
        Guido Günther <agx@...xcpu.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key

Hi Lucas,

On 2019-05-28 05:51, Lucas Stach wrote:
> Hi Angus,
> 
> Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie 
> (Purism):
>> Add the snvs power key.
>> 
>> > Signed-off-by: Angus Ainslie (Purism) <angus@...ea.ca>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
>> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 45d10d8efd14..5f93fd9662ae 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -8,6 +8,7 @@
>>  #include <dt-bindings/power/imx8mq-power.h>
>>  #include <dt-bindings/reset/imx8mq-reset.h>
>>  #include <dt-bindings/gpio/gpio.h>
>> +#include "dt-bindings/input/input.h"
>>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>>  #include <dt-bindings/thermal/thermal.h>
>>  #include "imx8mq-pinfunc.h"
>> @@ -463,6 +464,14 @@
>> >  					interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
>> >  						<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>> >  				};
>> +
>> > +				snvs_pwrkey: snvs-powerkey {
>> > +					compatible = "fsl,sec-v4.0-pwrkey";
>> > +					regmap = <&snvs>;
>> > +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> > +					linux,keycode = <KEY_POWER>;
>> +					wakeup-source;
> 
> Not all i.MX8MQ systems will have this functionality wired up at the
> board level, so this node needs to be disabled by default. The existing
>  i.MX6 and i.MX7 DTs seem to get this wrong.
> 

Ok I'll fix that for the next rev.

Thanks
Angus

> Regards,
> Lucas
> 
>> +				};
>> >  			};
>>  
>> > >  			clk: clock-controller@...80000 {