linux-kernel - Re: [PATCH] watchdog: gpio: add support for nowayout option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <553a3b7c-808f-12ac-3301-6a111d760c26@roeck-us.net>
Date:   Tue, 28 May 2019 06:26:26 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mans Rullgard <mans@...sr.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: gpio: add support for nowayout option

On 5/28/19 2:09 AM, Mans Rullgard wrote:
> Add support for the nowayout option in the gpio watchdog driver.
> 
> Signed-off-by: Mans Rullgard <mans@...sr.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/gpio_wdt.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c
> index ea77cae03c9d..63792bb70213 100644
> --- a/drivers/watchdog/gpio_wdt.c
> +++ b/drivers/watchdog/gpio_wdt.c
> @@ -17,6 +17,12 @@
>   #include <linux/platform_device.h>
>   #include <linux/watchdog.h>
>   
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout,
> +		"Watchdog cannot be stopped once started (default="
> +				__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> +
>   #define SOFT_TIMEOUT_MIN	1
>   #define SOFT_TIMEOUT_DEF	60
>   
> @@ -155,6 +161,7 @@ static int gpio_wdt_probe(struct platform_device *pdev)
>   	priv->wdd.timeout	= SOFT_TIMEOUT_DEF;
>   
>   	watchdog_init_timeout(&priv->wdd, 0, &pdev->dev);
> +	watchdog_set_nowayout(&priv->wdd, nowayout);
>   
>   	watchdog_stop_on_reboot(&priv->wdd);
>   
>