linux-kernel - Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiU=uFjJFEoiHFUr+ab73sJksaTBkfxvQwL1X6WJnhchqw@mail.gmail.com>
Date:   Tue, 28 May 2019 09:41:40 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

Hello YueHaibing,

On Tue, May 28, 2019 at 9:33 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>
> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe':
> arcx-anybus.c:(.text+0x9d6): undefined reference to `__devm_regmap_init_mmio_clk'
>
> Select REGMAP_MMIO to fix it.

Thank you for noticing this, I appreciate it !

However, when I run this patch through the scripts/checkpatch.pl
script, it reports
some issues. Could you fix and post v2 please?

checkpatch.pl output follows:

WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#68:
arcx-anybus.c:(.text+0x9d6): undefined reference to
`__devm_regmap_init_mmio_clk'

ERROR: DOS line endings
#87: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17:
+^Iselect REGMAP_MMIO^M$

total: 1 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.