[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190528140518.GU2623@hirez.programming.kicks-ass.net>
Date: Tue, 28 May 2019 16:05:18 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: "Liang, Kan" <kan.liang@...ux.intel.com>
Cc: mingo@...nel.org, acme@...hat.com, vincent.weaver@...ne.edu,
linux-kernel@...r.kernel.org, alexander.shishkin@...ux.intel.com,
ak@...ux.intel.com, jolsa@...hat.com, eranian@...gle.com
Subject: Re: [PATCH V2 1/3] perf/x86: Disable non generic regs for
software/probe events
On Tue, May 28, 2019 at 09:33:40AM -0400, Liang, Kan wrote:
> Uncore PMU doesn't support sampling. It will return -EINVAL.
> There is no regs support for counting. The request will be ignored.
>
> I think current check for uncore is good enough.
breakpoints then.. There's also no guarantee you covered all software
events, and the core rewrite will allow other per-task/sampling PMUs
too.
The approach you take is just not complete, don't do that.
Powered by blists - more mailing lists