linux-kernel - Re: [PATCH V2 1/3] perf/x86: Disable non generic regs for software/probe events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 May 2019 10:26:15 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mingo@...nel.org, acme@...hat.com, vincent.weaver@...ne.edu,
        linux-kernel@...r.kernel.org, alexander.shishkin@...ux.intel.com,
        ak@...ux.intel.com, jolsa@...hat.com, eranian@...gle.com
Subject: Re: [PATCH V2 1/3] perf/x86: Disable non generic regs for
 software/probe events



On 5/28/2019 10:05 AM, Peter Zijlstra wrote:
> On Tue, May 28, 2019 at 09:33:40AM -0400, Liang, Kan wrote:
>> Uncore PMU doesn't support sampling. It will return -EINVAL.
>> There is no regs support for counting. The request will be ignored.
>>
>> I think current check for uncore is good enough.
> 
> breakpoints then.. There's also no guarantee you covered all software
> events, and the core rewrite will allow other per-task/sampling PMUs
> too.
> 
> The approach you take is just not complete, don't do that.
> 

OK. I will send V3 base on your proposed patches.

Thanks,
Kan