linux-kernel - Re: [PATCH v3 3/3] tests: add close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhn7p8kd.fsf@concordia.ellerman.id.au>
Date:   Tue, 28 May 2019 13:22:10 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christian Brauner <christian@...uner.io>, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        torvalds@...ux-foundation.org, fweimer@...hat.com
Cc:     jannh@...gle.com, oleg@...hat.com, tglx@...utronix.de,
        arnd@...db.de, shuah@...nel.org, dhowells@...hat.com,
        tkjos@...roid.com, ldv@...linux.org, miklos@...redi.hu,
        Christian Brauner <christian@...uner.io>,
        linux-api@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 3/3] tests: add close_range() tests

Christian Brauner <christian@...uner.io> writes:
> This adds basic tests for the new close_range() syscall.
> - test that no invalid flags can be passed
> - test that a range of file descriptors is correctly closed
> - test that a range of file descriptors is correctly closed if there there
>   are already closed file descriptors in the range
> - test that max_fd is correctly capped to the current fdtable maximum
>
> Signed-off-by: Christian Brauner <christian@...uner.io>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Jann Horn <jannh@...gle.com>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Dmitry V. Levin <ldv@...linux.org>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Florian Weimer <fweimer@...hat.com>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: linux-api@...r.kernel.org
> Cc: linux-kselftest@...r.kernel.org
> ---
> v1: unchanged
> v2:
> - Christian Brauner <christian@...uner.io>:
>   - verify that close_range() correctly closes a single file descriptor
> v3:
> - Christian Brauner <christian@...uner.io>:
>   - add missing Cc for Shuah
>   - add missing Cc for linux-kselftest

Sorry I replied to v2, but I think my comments still apply:

https://lore.kernel.org/lkml/8736kzqpdm.fsf@concordia.ellerman.id.au/

cheers