linux-kernel - Re: [RFC 1/7] perf: arm64: Compile tests unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528161633.GB28492@lakrids.cambridge.arm.com>
Date:   Tue, 28 May 2019 17:16:33 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Raphael Gault <raphael.gault@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, peterz@...radead.org, catalin.marinas@....com,
        will.deacon@....com
Subject: Re: [RFC 1/7] perf: arm64: Compile tests unconditionally

On Tue, May 28, 2019 at 12:19:38PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 28, 2019 at 04:03:14PM +0100, Raphael Gault escreveu:
> > In order to subsequently add more tests for the arm64 architecture
> > we compile the tests target for arm64 systematically.
> 
> Humm, the subject doesn't match the description? I.e. it _was_
> unconditionally built, now it is only built if CONFIG_DWARF_UNWIND is
> set to 'y'.

Perhaps it's hard to read, but we haven't introduced new conditionality.

Previously we'd only build the tests directory if CONFIG_DWARF_UNWIND
was selected, so tests/dwarf-unwind.o was always dependent on that.

Now we always try to build the tests directory, and move the
CONFIG_DWARF_UNWIND guard specifically to tests/dwarf-unwind.o.

Thanks,
Mark.

> 
> - Arnaldo
>  
> > Signed-off-by: Raphael Gault <raphael.gault@....com>
> > ---
> >  tools/perf/arch/arm64/Build       | 2 +-
> >  tools/perf/arch/arm64/tests/Build | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/arch/arm64/Build b/tools/perf/arch/arm64/Build
> > index 36222e64bbf7..a7dd46a5b678 100644
> > --- a/tools/perf/arch/arm64/Build
> > +++ b/tools/perf/arch/arm64/Build
> > @@ -1,2 +1,2 @@
> >  perf-y += util/
> > -perf-$(CONFIG_DWARF_UNWIND) += tests/
> > +perf-y += tests/
> > diff --git a/tools/perf/arch/arm64/tests/Build b/tools/perf/arch/arm64/tests/Build
> > index 41707fea74b3..a61c06bdb757 100644
> > --- a/tools/perf/arch/arm64/tests/Build
> > +++ b/tools/perf/arch/arm64/tests/Build
> > @@ -1,4 +1,4 @@
> >  perf-y += regs_load.o
> > -perf-y += dwarf-unwind.o
> > +perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
> >  
> >  perf-y += arch-tests.o
> > -- 
> > 2.17.1
> 
> -- 
> 
> - Arnaldo