linux-kernel - Re: [PATCH] block: use KMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190528185059.GB25022@vader>
Date:   Tue, 28 May 2019 11:50:59 -0700
From:   Omar Sandoval <osandov@...ndov.com>
To:     Peng Wang <wangpeng15@...omi.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, Peng Wang <rocking@....edu.cn>
Subject: Re: [PATCH] block: use KMEM_CACHE macro

On Mon, May 27, 2019 at 07:48:35PM +0800, Peng Wang wrote:
> From: Peng Wang <rocking@....edu.cn>
> 
> Use the preferred KMEM_CACHE helper for brevity.

Reviewed-by: Omar Sandoval <osandov@...com>

> Signed-off-by: Peng Wang <rocking@....edu.cn>
> ---
>  block/blk-core.c | 3 +--
>  block/blk-ioc.c  | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 1bf83a0df0f6..841bf0b12755 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1789,8 +1789,7 @@ int __init blk_dev_init(void)
>  	if (!kblockd_workqueue)
>  		panic("Failed to create kblockd\n");
>  
> -	blk_requestq_cachep = kmem_cache_create("request_queue",
> -			sizeof(struct request_queue), 0, SLAB_PANIC, NULL);
> +	blk_requestq_cachep = KMEM_CACHE(request_queue, SLAB_PANIC);
>  
>  #ifdef CONFIG_DEBUG_FS
>  	blk_debugfs_root = debugfs_create_dir("block", NULL);
> diff --git a/block/blk-ioc.c b/block/blk-ioc.c
> index 5ed59ac6ae58..58c79aeca955 100644
> --- a/block/blk-ioc.c
> +++ b/block/blk-ioc.c
> @@ -408,8 +408,7 @@ struct io_cq *ioc_create_icq(struct io_context *ioc, struct request_queue *q,
>  
>  static int __init blk_ioc_init(void)
>  {
> -	iocontext_cachep = kmem_cache_create("blkdev_ioc",
> -			sizeof(struct io_context), 0, SLAB_PANIC, NULL);
> +	iocontext_cachep = KMEM_CACHE(io_context, SLAB_PANIC);

This will change the name of the slab in slabinfo, but I can't imagine
that matters.

>  	return 0;
>  }
>  subsys_initcall(blk_ioc_init);
> -- 
> 2.19.1
>